Add grade and score to the results QR link #15
Merged
+60
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results web page needs the letter grade and numeric score from the shared link, not only the BST start and placed sequences. TreeShareConfig: adds editable query keys for grade and score, and moves the default viewer path from /view to /results. Both accessors fall back to the canonical key name when the asset field is left blank, matching how start and placed already behave. TreeRunTracker.BuildViewerUrl: now takes the final Grade and score and appends grade and score params. The score is formatted with invariant culture so a machine with a comma decimal separator cannot corrupt the link. TreeResultQrDisplay.PrepareResultQrCode: now takes the run's RhythmScoreTracker, which is the same instance the result screen shows, so the QR and the on-screen stats can never disagree. A null tracker logs an error, finishes level tracking, and shows the QR fallback rather than encoding an incomplete link. ResultScreenController: passes the score tracker it already has to the QR prepare call. TreeShareConfig.asset: sets the new grade and score keys and the /results base URL for this project. Co-authored-by: Cursor <cursoragent@cursor.com>
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results web page needs the letter grade and numeric score from the shared link, not only the BST start and placed sequences.
TreeShareConfig: adds editable query keys for grade and score, and moves the default viewer path from /view to /results. Both accessors fall back to the canonical key name when the asset field is left blank, matching how start and placed already behave.
TreeRunTracker.BuildViewerUrl: now takes the final Grade and score and appends grade and score params. The score is formatted with invariant culture so a machine with a comma decimal separator cannot corrupt the link.
TreeResultQrDisplay.PrepareResultQrCode: now takes the run's RhythmScoreTracker, which is the same instance the result screen shows, so the QR and the on-screen stats can never disagree. A null tracker logs an error, finishes level tracking, and shows the QR fallback rather than encoding an incomplete link.
ResultScreenController: passes the score tracker it already has to the QR prepare call.
TreeShareConfig.asset: sets the new grade and score keys and the /results base URL for this project.